Fix pipe event accounting and aligned tablet failure reporting#18150
Open
Caideyipi wants to merge 3 commits into
Open
Fix pipe event accounting and aligned tablet failure reporting#18150Caideyipi wants to merge 3 commits into
Caideyipi wants to merge 3 commits into
Conversation
Caideyipi
changed the title
jt2594838
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two independent fixes.
Pipe:
UnboundedBlockingPendingQueue#pollLast()now updates event-count accounting when it removes the tail event, consistent with the other poll paths.PipeRealtimeDataRegionSourceswaps them out, avoiding leaked references/accounting.Write:
TsFileProcessor.insertTablet()no longer overwrites existing per-row failure statuses withSUCCESS_STATUSafter aligned tablet insertion.AlignedTVList, because failed rows are still appended and masked by bitmap rather than skipped. This avoids underestimating TVList array memory.Tests
mvn spotless:apply -pl iotdb-core/node-commonsmvn -pl iotdb-core/node-commons -Dtest=UnboundedBlockingPendingQueueTest testmvn spotless:apply -pl iotdb-core/datanodegit diff --checkmvn test -pl iotdb-core/datanode -Dtest=TsFileProcessorTest#alignedTabletKeepsFailedStatusesAndCountsWrittenRows(blocked by existing generated-sources/freemarker compile errors unrelated to this change)